Merge pull request #291 from barspi/master

Avoid long-lived reference to DOM Element within lambda closure
jpos · Nov 20, 2023 · 3e8ebd7 · 3e8ebd7
2 parents b8728ad + bb2e99e
commit 3e8ebd7
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/modules/qrest/src/main/java/org/jpos/qrest/participant/Router.java b/modules/qrest/src/main/java/org/jpos/qrest/participant/Router.java
@@ -72,13 +72,14 @@ public String select(long id, Serializable context) {
     public void setConfiguration(Element e) throws ConfigurationException {
         try {
             for (Element r : e.getChildren("route")) {
+                String name = r.getAttributeValue("name");
                 routes.computeIfAbsent(
                   r.getAttributeValue("method"),
                   k -> new ArrayList<>()).add(
                     new Route<>(
                       r.getAttributeValue("path"),
                       r.getAttributeValue("method"),
-                      (t, s) -> r.getAttributeValue("name"))
+                      (t, s) -> name)
                 );
             }
         } catch (Throwable t) {