Issue 41 cimulator buid #47
Conversation
increased timeout
…chase/QOKit into issue_41_cimulator_buid black .
setup.py
Outdated
| super().run | ||
| except Exception as e: | ||
| print("No C/C++ enviroment setup to compile the C simulator. Installing Python Simulator") | ||
| if python_only is not None: |
There was a problem hiding this comment.
Can this condition be used directly on line 23 below instead of creating an intermediary QOKIT_PYTHON_ONLY variable?
There was a problem hiding this comment.
Need that env variable to control workflow/debug
There was a problem hiding this comment.
changed to if python_only is not None:
There was a problem hiding this comment.
Looks like more tests are failing now...
There was a problem hiding this comment.
Looks like more tests are failing now...
It should right? This is python build only no c-build
There was a problem hiding this comment.
Why did the tests start failing though? Responding in this thread, but not sure which change triggered it
There was a problem hiding this comment.
Why did the tests start failing though? Responding in this thread, but not sure which change triggered it
E AssertionError: assert 'c' in ['python']
E + where ['python'] = get_available_simulator_names('x')
Trigged by env variable setup QOKIT_PYTHON_ONLY=True. Intended behavior for that test.
Why did the tests start failing though? Responding in this thread, but not sure which change triggered it
There was a problem hiding this comment.
If it's intended, it should catch the error, no?
tests/test_simulators_builds.py
Outdated
| from qokit.fur import get_available_simulator_names | ||
|
|
||
| # when fail tests only runs in Github actions. Change to true to run locally | ||
| IN_GITHUB_ACTIONS = os.getenv("GITHUB_ACTIONS") == "fales" |
tests/test_simulators_builds.py
Outdated
| IN_GITHUB_ACTIONS = os.getenv("GITHUB_ACTIONS") == "fales" | ||
|
|
||
|
|
||
| @pytest.mark.skipif(IN_GITHUB_ACTIONS, reason="Test runs only in Github Actions.") |
There was a problem hiding this comment.
TODO: add graceful handling of this in python pipeline
|
Status update: there are two main problems |
|
Update: the Mac build failure is due to clang not supporting openmp. Installing GCC should resolve the issue, but I can't get make to use the right compiler |
|
fixed following pipeline issues:
|
Add test which check that c simulator is built correctly