Test Request #18
Merged
Test Request #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
September 26, 2023 16:34
|
why this failed - |
rsln-s
requested changes
Oct 2, 2023
.github/workflows/qokit-package.yml
Outdated
| branches: [ "main", "**" ] | ||
| pull_request: | ||
| branches: [ "main" ] | ||
| #branches: [ "main", "**" ] |
There was a problem hiding this comment.
Is there a reason the lines are commented out and not simply deleted?
| branches: [ "main", "**" ] | ||
| pull_request: | ||
| branches: [ "main" ] | ||
| #branches: [ "main", "**" ] |
There was a problem hiding this comment.
Is there a reason the lines are commented out and not simply deleted?
There was a problem hiding this comment.
I commented those lines to test the GitHub Action for publishing. I have
- reverted the commented lines for
- .github/workflows/qokit-package.yml
- .github/workflows/qokit-python-only.yml
Deleted pypi-test.yml and merged that code in pypi-test-publish.yml
Modified pypi-publish.yml to publish to pypi on release tag
I have updated codes and all actions are green
rsln-s
approved these changes
Oct 3, 2023
alex124585
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This to test GA action from feature branch do not approve