Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove snake case #574

Open
wants to merge 2 commits into
base: 1.1-dev
Choose a base branch
from
Open

Conversation

koenpunt
Copy link
Collaborator

@koenpunt koenpunt commented Jun 11, 2017

This reenables two accidentally disabled tests. This also removes the OCD snake_case patch that once was introduced.

@koenpunt koenpunt force-pushed the remove-snake-case branch 2 times, most recently from 745d7d2 to e935a9a Compare June 11, 2017 21:13
@koenpunt koenpunt mentioned this pull request Jun 12, 2017
27 tasks
these tests have been in here since the beginning without them being run.
this was unnecessary added complexity
@brandondrew
Copy link

Why would anyone ever want to disable snake case? It's far more readable than camel case. Try reading these two function names, and see which one allows your eyes to move more quickly:

testExtractAndValidateOptionsNopeBecauseWasntAtEnd()
test_extract_and_validate_options_nope_because_wasnt_at_end()

There's no contest. The first one requires you to move very slowly to find the (imaginary/invisible) word breaks. The second one is almost as fast as reading normal English text with spaces. Because we spend more time reading code more than we spend writing code, it makes sense to move to snake case and away from camel case as often as circumstances permit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants