New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix computeFaceNormal: use corner whose angle is closest to right angle for cross product #131

Open

henkson wants to merge 2 commits into jpcy:master from henkson:issue#130

henkson commented Dec 21, 2023

This change provides a fix for issue #130.

adding a method angle that calculates the angle between 2 Vector3 objects
modifying the Mesh.computeFaceNormal method: verify the angles of all face vertices, and use the vertex whose angle is the closest to a right angle (90°). This makes the cross product numerically more stable.


          fix computeFaceNormal: use corner whose angle is closest to right ang…

621e236

…le for cross product

Author

henkson commented Dec 21, 2023

Benchmarking the code with over 5000 test meshes doesn't show any performance impact.


          fix build on windows systems; use M_PI_2 constant instead of M_PI * 0.5f

9b986ca

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment