-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nvapi: Reflex support through LatencyFleX #66
Conversation
Thanks a lot for the PR and the questions regarding how to wire this all together. This is what comes to my mind after briefly looking at this PR:
About tests, yeah, I prefer to have tests for the different return codes (with and without lfx) and validations that we actually call lfx, similar like the tests for nvml related methods. The tests for Let me know your thoughts. |
I think all of these suggestions look good, and that clears a lot of my confusions about code organization. Thanks! I'll try to implement this in the next few days. |
dd26cbd
to
46dea35
Compare
Thanks for the patience, I have addressed the review comments and added some tests. |
CLion auto refactor went rogue in a few places, removed that and another unrelated change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for improving this PR. I've added some review comments, mostly just smaller things. Overall this looks already really good.
8882376
to
c985e96
Compare
Thanks for another iteration of review comments, the code now feels a bit more cleaner. I have pushed v2 to address the review comments, plus a rebase to also apply the refactor into newly added tests. I'll push v3 when I have addressed #66 (comment) (and any extra review comments if you have). |
Hi @ishitatsuyuki thanks again for your changes. Please see my answers to your questions and some other smaller comments. I hope your are not yet tired about all the nits and tests, we are really close ;) |
Just a status update: I'm still working through refactoring the binding DLLs but I'm a bit short on time due to exams. Can't promise when I can get back to this, but I'll try to not delay this too much. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v3 changes are now pushed. I did a rebase, and went a bit lazy by squashing v2 into v1. Hopefully that's fine.
A LFX update with new DLL naming will be published soon after I sort out some documentation changes.
Pushed v4, reorganizing the fallback logic. I also added back the cast of |
All good now and merged, thanks a lot for the contribution and for your patience! |
This has been tested for a while on Radeon 5700 XT, but I haven't received any user reports about NV.
Edit: apparently multiple users have been using Nvidia to run this fine.
Some implementation questions: