fix: full rewrite of ScopeProvider to address known issues

- fixes: #25, #36
jotaijs · Sep 25, 2024 · 3788511 · 3788511
1 parent a027650
commit 3788511
Show file tree

Hide file tree

Showing 41 changed files with 2,130 additions and 924 deletions.
diff --git a/__tests__/derive/baseTests/react/abortable.test.tsx b/__tests__/derive/baseTests/react/abortable.test.tsx
@@ -11,26 +11,24 @@ describe('abortable atom test', () => {
     const resolve: (() => void)[] = [];
     const derivedAtom = atom(async (get, { signal }) => {
       const count = get(countAtom);
-      await new Promise<void>((r) => resolve.push(r));
+      await new Promise<void>((r) => {
+        resolve.push(r);
+      });
       if (signal.aborted) {
         ++abortedCount;
       }
       return count;
     });
 
-    const Component = () => {
+    function Component() {
       const count = useAtomValue(derivedAtom);
       return <div>count: {count}</div>;
-    };
+    }
 
-    const Controls = () => {
+    function Controls() {
       const setCount = useSetAtom(countAtom);
-      return (
-        <>
-          <button onClick={() => setCount((c) => c + 1)}>button</button>
-        </>
-      );
-    };
+      return <button onClick={() => setCount((c) => c + 1)}>button</button>;
+    }
 
     const { findByText, getByText } = render(
       <StrictMode>
@@ -75,19 +73,15 @@ describe('abortable atom test', () => {
       return count;
     });
 
-    const Component = () => {
+    function Component() {
       const count = useAtomValue(derivedAtom);
       return <div>count: {count}</div>;
-    };
+    }
 
-    const Controls = () => {
+    function Controls() {
       const setCount = useSetAtom(countAtom);
-      return (
-        <>
-          <button onClick={() => setCount((c) => c + 1)}>button</button>
-        </>
-      );
-    };
+      return <button onClick={() => setCount((c) => c + 1)}>button</button>;
+    }
 
     const { findByText, getByText } = render(
       <StrictMode>
@@ -131,12 +125,12 @@ describe('abortable atom test', () => {
       return count;
     });
 
-    const Component = () => {
+    function Component() {
       const count = useAtomValue(derivedAtom);
       return <div>count: {count}</div>;
-    };
+    }
 
-    const Parent = () => {
+    function Parent() {
       const setCount = useSetAtom(countAtom);
       const [show, setShow] = useState(true);
       return (
@@ -146,7 +140,7 @@ describe('abortable atom test', () => {
           <button onClick={() => setShow((x) => !x)}>toggle</button>
         </>
       );
-    };
+    }
 
     const { findByText, getByText } = render(
       <StrictMode>
@@ -183,19 +177,15 @@ describe('abortable atom test', () => {
       return count;
     });
 
-    const Component = () => {
+    function Component() {
       const count = useAtomValue(derivedAtom);
       return <div>count: {count}</div>;
-    };
+    }
 
-    const Controls = () => {
+    function Controls() {
       const setCount = useSetAtom(countAtom);
-      return (
-        <>
-          <button onClick={() => setCount((c) => c + 1)}>button</button>
-        </>
-      );
-    };
+      return <button onClick={() => setCount((c) => c + 1)}>button</button>;
+    }
 
     const { findByText, getByText } = render(
       <StrictMode>