Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for the PCB_MOUNT controller mount. #97

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fixes for the PCB_MOUNT controller mount. #97

wants to merge 4 commits into from

Conversation

mjonuschat
Copy link

A couple of small fixes that should make using the PCB_MOUNT controller_mount_type less surprising:

  1. usb_holder_size and usb_holder_thickness information moved to config as multiple calculations are based on those values.
  2. Use the TRRS hole size information from the configuration, it was overridden / hardcoded in the trrs_hole() method
  3. Use the z-axis offset from configuration for the TRRS hole. Calculating it based on the size of the whole and the thickness of the PCB holder was unexpected and couldn't be manually adjusted.
  4. Use the z-axis offset from the configuration for the USB hole. Same as for the TRRS hole the automatic calculation was unexpected and overriding the configured value.

@mjonuschat
Move usb_holder_size/usb_holder_thickness to config
dff189e 
Values were hardcoded in dactyl_manuform.py, move them to the config for customization.
@mjonuschat
TRRS hole: Use Z-axis offset from configuration
a0ee2cd 
Instead of ignoring the configuration and calculating it based on the
configured TRRS Hole size and the PCB Holder position on the Z-axis.

Updated the configuration so that the default values match the previously
calculated values.
@mjonuschat
TRRS hole: use the size information from the configuration
9358902 
Configuration was ignored / overwritten with a hardcoded value inside of
the trrs_hole() method.
@mjonuschat
USB hole: Use the Z-axis offset from configuration
37c6d53 
Allow overriding the Z-axis offset of the USB hole instead of calculating
it based on the size of the USB hole and the size of the height of the PCB
holder.

Useful when socketing controllers and the offset is not only related to
the thickness of the PCB holder.

Updated the configuration defaults to match the previously calculated value.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mjonuschat