Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the "Robust peak detection algorithm (using z-scores)" from SO. #293

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

hv10
Copy link

@hv10 hv10 commented Nov 20, 2024

Hi dear Maintainers,

thanks again for the great package - as I have profited from it greatly I wanted to give something back - by adding a new Algorithm.

I have been using the algorithm from the merge request myself quite a bit.
It is able to do peak detection in univariate real-time timeseries.
AFAIK the algorithm has been made public under attribution.

The source would be:

Brakel, J.P.G. van (2014). "Robust peak detection algorithm using z-scores". Stack Overflow. Available at: https://stackoverflow.com/questions/22583391/peak-signal-detection-in-realtime-timeseries-data/22640362#22640362 (version: 2020-11-08).

I am currently in the process of extending it (multivariate use case) - and would likely be able and willing to add the extensions as well, as I see this package as a great fit for these algorithms.

Let me know what I would need to do to make this fit both in spirit and in line with code standards of your package.

~hv10

EDIT: The algorithm(s) are also online and take constant memory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant