-
Notifications
You must be signed in to change notification settings - Fork 793
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
name = "blackd", | ||
meta = { | ||
url = "https://github.com/psf/black", | ||
description = "The uncompromising Python code formatter", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need to be updated? Ideally this would clarify the difference between black
and blackd
and also mention how to configure the source.
Also, will blackd
automatically pick up config files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the meta info, not sure if the lines can be that long.
It can't pick up config files at all, the only possible configuration are the options I listed. It is quite limited.
@@ -0,0 +1,84 @@ | |||
local curl = require("plenary.curl") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you move this require statement into the generator callback? At the moment it's breaking the documentation autogen script, since the script doesn't have access to Plenary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
name = "blackd", | ||
meta = { | ||
url = "https://github.com/psf/black", | ||
description = "blackd is a small HTTP server that exposes Black’s functionality over a simple protocol. The main benefit of using it is to avoid the cost of starting up a new Black process every time you want to blacken a file.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also mention that the only way to configure the formatter is by using the provided config options, i.e. that it won't pick up on config files at all? If you'd like to split info across lines, you can use the meta.notes
key.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Thank you! |
#1239