Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crop text in middle instead of decimate it #809

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

wassname
Copy link

@wassname wassname commented Oct 29, 2024

A few problems:

  • for cropping we were discarding every N sentence, this creates garbage text
  • we were calculating the max tokens wrong (or at least the logic didn't make sense to me)

So I've

  • change the cropText for the whole extension to remove the excess text from the middle and replace it with a warning "this text has had X% removed"
  • use \n instead of , for more natural text
  • change the way we count the token limit to help us use all of it

#800

@wassname wassname changed the title crop transcript in middle instead of decimate it crop text in middle instead of decimate it Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant