Display trait for Game, as PGN string #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is now ready for review. A small detail remains, only for the test I added: promotions are not considered valid SAN moves, hence the test does not include moves like "a8=Q". But those moves are handled correctly, and everything is functional as far as I can tell. Poke @jordanbray! :) |
The file is returned in lowercase, because this is used for the PGN string
The game can be transcribed as a PGN string. Ambiguous moves, promotions and checks are all handled.
Ten0
reviewed
Sep 21, 2024
Comment on lines
+42
to
+43
| pgn: String, | ||
| move_number: usize, |
There was a problem hiding this comment.
both start_pos and all moves are in Game, so it doesn't look like it also always needs to store the PGN: if people use this Game struct for anything else, this is extra useless cost.
These should probably just be local variables of the Display implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#69