Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pydantic shims #85

Merged
merged 7 commits into from
Jul 28, 2023
Merged

Use pydantic shims #85

merged 7 commits into from
Jul 28, 2023

Conversation

joostlek
Copy link
Owner

Proposed Changes

Pydantic v2 bundled the v1 version with itself, so the first obvious step is to remove the constraint and allow v2 to be installed using the v1 API shim.

It looks like a lot of the field internals changed so I will have to go back through each import, update them to allow the v2 version and test before we can use v2.

@joostlek joostlek added the dependencies Upgrade or downgrade of project dependencies. label Jul 21, 2023
@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #85 (5d4b200) into main (60080dc) will not change coverage.
Report is 4 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #85   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          213       214    +1     
  Branches        20        20           
=========================================
+ Hits           213       214    +1     
Files Changed Coverage Δ
src/python_opensky/models.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Jul 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@joostlek joostlek merged commit 1964cf8 into main Jul 28, 2023
26 checks passed
@joostlek joostlek deleted the pydantic branch July 28, 2023 09:27
@github-actions github-actions bot locked and limited conversation to collaborators Jul 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Upgrade or downgrade of project dependencies.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant