Align Service Hostnames with Dockerfile Defaults for Redis and RabbitMQ #1217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The service is configured via a Dockerfile, which is hard-coded to use the following environment variables. Therefore, for the default installation, this file should point to 'rabbitmq' instead of 'rabbitmq-broker'. # Default Redis and RabbitMQ connections ENV AMQP_BROKER_HOST 'rabbitmq' ENV AMQP_BROKER_PORT 5672 ENV REDIS_CLIENT_HOST 'redis' ENV REDIS_CLIENT_PORT 6379
The service is configured via a Dockerfile, which is hard-coded to use the following environment variables. Therefore, for the default installation, this file should point to 'redis' instead of 'redis-server'. # Default Redis and RabbitMQ connections ENV AMQP_BROKER_HOST 'rabbitmq' ENV AMQP_BROKER_PORT 5672 ENV REDIS_CLIENT_HOST 'redis' ENV REDIS_CLIENT_PORT 6379
The service is configured via a Dockerfile, which is hard-coded to use the following environment variables. Therefore, for the default installation, this file should point to 'redis' instead of 'redis-server'. as well for rabbitmq from rabbitmq-broker # Default Redis and RabbitMQ connections ENV AMQP_BROKER_HOST 'rabbitmq' ENV AMQP_BROKER_PORT 5672 ENV REDIS_CLIENT_HOST 'redis' ENV REDIS_CLIENT_PORT 6379
Update jasmin.yml
Update redis.yml
Update rabbitmq.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1212
Description
The Redis and RabbitMQ services are configured via a Dockerfile, which is hard-coded to use the following environment variables. Therefore, for the default installation, jasmin.yml, redisy.yml and rabbitmq.yml files should point to 'rabbitmq' instead of 'rabbitmq-broker' and 'redis' instead of 'redis-server'.
Issue References:
https://groups.google.com/g/jasmin-sms-gateway/c/k3CFXWGFW-w
#1212
#944
Checks
Additional Information