Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for named teams #61

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Support for named teams #61

wants to merge 3 commits into from

Conversation

doriancodes
Copy link
Contributor

@doriancodes doriancodes commented Oct 8, 2022 •
edited
Loading

Proposed Changes

  • added NamedTeams typealias
  • edited Config to accept NamedTeams
  • refactored createAuthorsSignatures method in GCommit
  • added fetchAuthors method to return list of Author either from NamedTeams or from tags
  • added documentation

Issue

Closes/Fixes # #52

@doriancodes
[support for named teams]
ecb48df 
- added NamedTeams typealias
- edited Config to accept NamedTeams
- refactored createAuthorsSignatures method in GCommit
- added fetchAuthors method to return list of Author either from NamedTeams or from tags
@doriancodes
[support for named teams]
f9a9645 
- added NamedTeams typealias
- edited Config to accept NamedTeams
- refactored createAuthorsSignatures method in GCommit
- added fetchAuthors method to return list of Author either from NamedTeams or from tags
- added documentation
@doriancodes
Merge remote-tracking branch 'origin/support_for_named_teams' into su…
a411b57 
…pport_for_named_teams
@doriancodes
Copy link
Contributor Author

These lines:
val fp = popen(command, "r") ?: error("Failed to run command: $STATUS_COMMAND")
val status = pclose(fp)
seems to create problems with the build on windows: https://github.com/jooaodanieel/GCommit/actions/runs/3211191983/jobs/5249189321#step:5:62

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@doriancodes