Move to html-minifier-terser to support ES6 🔧 #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems tests failed because I will add that requirement and change travis build to test only on 6 and above |
|
That requirement already existed, but Travis was building for non supported node versions.... 🤦 |
|
sorry for the delay, and thanks for the PR. We'll review and merge ASAP! |
|
Cool! Looking forward to it.
…On Tue, Nov 26, 2019 at 2:44 AM Jon Schlinkert ***@***.***> wrote:
sorry for the delay, and thanks for the PR. We'll review and merge ASAP!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#104?email_source=notifications&email_token=AAIU5ZSGJS7V36X57YGUY4TQVSEQHA5CNFSM4JKP2JH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFEQLDQ#issuecomment-558433678>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIU5ZVM4R34CXVOJQ6776TQVSEQHANCNFSM4JKP2JHQ>
.
--
Rodrigo Graça.
|
|
@jonschlinkert Hi, is there any hope this will be merged? |
|
Hey! Seems the webpack team just released version 4 using It would be good if we could merge this PR and also use Thanks! ❤️ |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As debated in this thread
html-minifieris usinguglify-jswhich doesnt support ES6, so if you have any ES6 in your HTML it doesnt compress it.This new fork created by @DanielRuf changes
uglify-jsto the latestterserversion.This change is really need nowadays since if you include even 1 line of ES6 the whole JS does not compress.
P.S. I can send another PR bumping this package version if you want. (Nothing should break but since this is a big change I would bump to 6.0.0)