-
-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to js-yaml v4 #137
base: master
Are you sure you want to change the base?
Update to js-yaml v4 #137
Conversation
See #136 for more info |
I published https://www.npmjs.com/package/@gr2m/gray-matter for the time being. You also need to update |
This fixes a bug with numbers as well: currently, @robertmassaioli any chance this could be merged? |
@jonschlinkert Can we get this merged? We use js-yaml alongside gray-matter (to prevent using several packages for yaml). Right now we are forced to use v3 of js-yaml until this is merged ❤️ |
I don’t want to use js-yaml at all. The yaml package is better IMHO.Sent from my iPhoneOn Apr 27, 2024, at 1:03 AM, Gregor Adams ***@***.***> wrote:
@jonschlinkert Can we get this merged? We use js-yaml alongside gray-matter (to prevent using several packages for yaml).
Right now we are forced to use v3 of js-yaml until this is merged ❤️
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
@jonschlinkert I fully agree, I removed yaml and switched to js-yaml for the sole reason of preventing duplicate packages for parsing yaml. It looks like a rather easy refactor: https://github.com/jonschlinkert/gray-matter/blob/master/lib/engines.js#L15-L18 I can see if I can spin up a PR for that, if you're open. |
Looks like someone already did the work and was waiting for a response? |
Updating to js-yaml 4.1.0 will dramatically reduce bundle size (~70%) and only requires replacing two function names.