Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #570 Keyboard Hides when sidemenu appears but after closing side menu … #654

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MichaelHuyp
Copy link

fix issue #570

@MichaelHuyp MichaelHuyp changed the title fix Keyboard Hides when sidemenu appears but after closing side menu … fix #570 Keyboard Hides when sidemenu appears but after closing side menu … Oct 15, 2020
@MichaelHuyp
Copy link
Author

@jonkykong
dismiss(animated: flag, completion: completion) will restore the keyboard twice when the sidemenu Closed but transitionController?.handle(state: .finish) not

@jonkykong
Copy link
Owner

@MichaelHuyp have you tested this on iOS 13 and below? It only seems to produce a change on iOS 14.

@MichaelHuyp
Copy link
Author

@jonkykong
Yes, our company uses your framework, Thank you very much for your SideMenu component.
Our QA tested this on iOS 13 and below. The same problem will happen.
The previous interface has a keyboard to open. Then Open the SideMenu and Close. The keyboard will Appeared twice.
After me debug many times, I found this is caused by dismiss(animated: flag, completion: completion)

@jonkykong
Copy link
Owner

jonkykong commented Oct 18, 2020

@MichaelHuyp when I test it on iOS 12 simulator I noticed the keyboard will briefly flash when SideMenu is dismissed. There were also strange behaviors that happened when pushing/presenting from SideMenu after the keyboard was showing. I'm not saying that your code caused these issues; but it does not appear to have resolved them. iOS 14 appears smoother when showing/hiding SideMenu, but pushing/presenting still has strange keyboard animations.

@MichaelHuyp
Copy link
Author

@jonkykong keyboard will briefly flash when SideMenu is dismissed when call dismiss(animated: flag, completion: completion).But I noticed that the SideMenu is closed by gesture drag, it will not briefly flash. Maybe this code does not appear to have resolved problem, but keyboard will not briefly flash : )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants