Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to issue #4 and test case #30

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Fix to issue #4 and test case #30

wants to merge 6 commits into from

Conversation

juanparati
Copy link

It seems that issue #4 is still present.

I included a test case.

@jonhoo
Copy link
Owner

jonhoo commented Dec 6, 2015

It's great that you fixed this, but please submit a PR with only the relevant changes. If I merge this, I'll also get all your other commits that are being discussed elsewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants