Skip to content

Commit

Permalink
actions: fix artifact name conflict using download-artifact v4
Browse files Browse the repository at this point in the history
This issue caused the android binaries to not be released. See
KhronosGroup#7449
  • Loading branch information
johnzupin committed Feb 6, 2024
1 parent bccc5a7 commit 75f8358
Showing 1 changed file with 13 additions and 16 deletions.
29 changes: 13 additions & 16 deletions .github/workflows/sdk_android_build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ jobs:
- name: Upload artifacts
uses: actions/upload-artifact@v4
with:
name: vvl-android
name: vvl-android-${{ matrix.abi }}
path: ./build-android/libs/lib/

release:
Expand Down Expand Up @@ -112,20 +112,16 @@ jobs:
fail-fast: false
matrix:
config:
- {
name: "Upload Android Release Tar Gzip Artifact",
artifact: "vvl-android",
command: "tar czf",
suffix: "tar.gz",
type: "application/x-gtar"
}
- {
name: "Upload Android Release Zip Artifact",
artifact: "vvl-android",
command: "zip -r",
suffix: "zip",
type: "application/zip"
}
- name: "Upload Android Release Tar Gzip Artifact"
artifact: "vvl-android"
command: "tar cvzf"
suffix: "tar.gz"
type: "application/x-gtar"
- name: "Upload Android Release Zip Artifact"
artifact: "vvl-android"
command: "zip -r"
suffix: "zip"
type: "application/zip"
steps:
- name: Get sdk version string
id: get_sdk_version
Expand All @@ -135,8 +131,9 @@ jobs:
- name: Download artifacts
uses: actions/download-artifact@v4
with:
name: ${{ matrix.config.artifact }}
path: ./android-binaries-${{ steps.get_sdk_version.outputs.sdk_version }}
merge-multiple: true
pattern: ${{ matrix.config.artifact }}-*
- name: Make release artifacts
run: |
${{ matrix.config.command }} android-binaries-${{ steps.get_sdk_version.outputs.sdk_version }}.${{ matrix.config.suffix }} android-binaries-${{ steps.get_sdk_version.outputs.sdk_version }}
Expand Down

0 comments on commit 75f8358

Please sign in to comment.