Features/add ignore case enhancement #12
Conversation
|
+1 |
|
@NoxPhoenix Good use case example |
|
Cool, feel free to comment on anything you would like changed. I did my best to follow the style you had in place. |
|
@johntimothybailey How are we looking on this? |
|
@NoxPhoenix thank you for the follow up! Not sure why one of the tests are passing and will comment on the line itself. I'm upgrading the project and dropping support for Node 4, which will help. I'm going to release the upgrades in a few phases. |
lib/chai-sorted.js
Outdated
| var useDescendingOrder = typeof options === 'object' ? !!options.descending : false | ||
|
|
||
| if (options.ignoreCase) { | ||
| return array.map(function (item) { |
There was a problem hiding this comment.
@NoxPhoenix While this should cause a failure in the tests I think it passes because it results in being truthy. Nonetheless, this should be array = array.map(function
There was a problem hiding this comment.
Ah, yeah. That makes sense. It was completely skipping the assertion. That is a good catch. Pushing the fix now.
|
That is cool about dropping the node 4 support. I had originally wrote this alot cleaner before I realized it had backwards compatibility that far. |
|
How is this looking now? It would great to get this in before you start your update so that you can update the new code as you refactor the rest! |
|
Hi @johntimothybailey, Any update on when this feature is going to be merged? |
|
@johntimothybailey How is this looking? |
|
@johntimothybailey any chance to get this merged and released? |
This adds the option
in order to get a closer result to alphaNumeric sorting like what returns from a sql db in
ORDER BY