Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customize page number entirely #443

Merged
merged 8 commits into from
May 27, 2024
Merged

Customize page number entirely #443

merged 8 commits into from
May 27, 2024

Conversation

johnfercher
Copy link
Owner

@johnfercher johnfercher commented May 26, 2024

Description

  • Customize page number props entirely

Related Issue

#412

Checklist

check with "x", ONLY IF APPLIED to your change

  • All methods associated with structs has func (<first letter of struct> *struct) method() {} name style.
  • Wrote unit tests for new/changed features.
  • Followed the unit test when,should naming pattern.
  • All mocks created with m := mocks.NewConstructor(t).
  • All mocks using m.EXPECT().MethodName() method to mock methods.
  • Updated docs/doc.go and docs/*
  • Updated example_test.go.
  • Updated README.md
  • New public methods/structs/interfaces has comments upside them explaining they responsibilities
  • Executed make dod with none issues pointed out by golangci-lint

@johnfercher johnfercher changed the title Customiza page number entirely Customize page number entirely May 26, 2024
Copy link

codecov bot commented May 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.64%. Comparing base (97de544) to head (5a56dc8).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #443      +/-   ##
==========================================
+ Coverage   84.16%   85.64%   +1.49%     
==========================================
  Files          61       61              
  Lines        2114     2144      +30     
==========================================
+ Hits         1779     1836      +57     
+ Misses        308      281      -27     
  Partials       27       27              
Flag Coverage Δ
unittests 85.64% <100.00%> (+1.49%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnfercher johnfercher merged commit 7899180 into master May 27, 2024
7 checks passed
@johnfercher johnfercher deleted the feature/page-number branch May 27, 2024 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant