Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/Expose FPDF AddUTF8FontFromBytes method #255

Merged
merged 4 commits into from
Sep 12, 2023
Merged

Feature/Expose FPDF AddUTF8FontFromBytes method #255

merged 4 commits into from
Sep 12, 2023

Conversation

thijsheijden
Copy link
Contributor

@thijsheijden thijsheijden commented Sep 12, 2023

Description

Related Issue

Checklist

check with "x", if applied to your change

  • All methods associated with structs has func (s *struct) method() {} name style.
  • Wrote unit tests for new/changed features.
  • Updated docs/doc.go
  • Updated pkg/pdf/example_test.go
  • Updated README.md
  • Updated all examples inside internal/examples
  • New public methods/structs/interfaces has comments upside them explaining they responsibilities
  • Executed make dod with none issues pointed out by golangci-lint and goreportcard-cli

@thijsheijden thijsheijden marked this pull request as ready for review September 12, 2023 14:39
@thijsheijden
Copy link
Contributor Author

I can replace the os.ReadFile with ioutil.ReadFile to make this work in Go 1.13

Go 1.13 does not have this method.
@johnfercher
Copy link
Owner

LGTM, actually we will update the go version soon. Also the linter should not be linting this in example_test.

@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02% 🎉

Comparison is base (b22cfd1) 92.93% compared to head (de46f7f) 92.95%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #255      +/-   ##
==========================================
+ Coverage   92.93%   92.95%   +0.02%     
==========================================
  Files          11       11              
  Lines         792      794       +2     
==========================================
+ Hits          736      738       +2     
  Misses         49       49              
  Partials        7        7              
Flag Coverage Δ
unittests 92.95% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/pdf/pdf.go 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@F-Amaral F-Amaral merged commit 8ab782c into johnfercher:master Sep 12, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants