Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore GitHub Action for building Debian package #1065

Merged
merged 6 commits into from
Aug 28, 2024
Merged

Conversation

johnfactotum
Copy link
Owner

No description provided.

# Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
- uses: actions/checkout@v2

- run: sudo apt install build-essential debhelper meson gettext pkg-config libglib2.0-dev gjs appstream
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my computer, it does not build without the new build dependencies added here (they were not necessary in Foliate version 2).

Copy link
Contributor

@archisman-panigrahi archisman-panigrahi Nov 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, now it does not build because Ubuntu 22.04 repositories have too old versions of gjs (and probably other software too). We probably need to wait for 24.04 GitHub action image so that it can generate a deb package.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or add an option to skip the dependency checks. But that makes no sense, either. Those dependencies are supposed to be run-time dependencies. Either we're using Meson wrong and should specify run-time dependencies another way, or Meson should be skipping these checks automatically when building a package.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we're doing anything wrong, cause Meson says:

Run-time dependency gjs-1.0 found: YES 1.78.0
Run-time dependency gtk4 found: YES 4.12.3
Run-time dependency libadwaita-1 found: YES 1.4.0
Run-time dependency webkitgtk-6.0 found: YES 2.42.2

So they are run-time dependencies indeed.

This means it could be the same bug that requires you to install desktop-file-utils.

@johnfactotum johnfactotum force-pushed the github-action-deb branch 2 times, most recently from 5bf02d2 to a1a8edf Compare November 14, 2023 01:38
@jbicha
Copy link

jbicha commented Jan 24, 2024

I believe I can help here.

Why do you want to build a Debian package? There are different reasons and they might mean we handle this in different ways. Here are some:

  • Just checking if Foliate is buildable on Debian
  • Distribute nightly builds
  • Make it easier to install on your computer

Also, the commit message says Debian but this is actually being built on Ubuntu.

@johnfactotum
Copy link
Owner Author

The action existed in v2.x. It was mainly for providing a deb package (nightly or otherwise), though it did also function as a check.

Also, the commit message says Debian but this is actually being built on Ubuntu.

Well, I used the term "Debian package" to refer to the deb format. But it was mainly intended for Ubuntu.

@archisman-panigrahi
Copy link
Contributor

@johnfactotum It should work with the new 24.04 based builder github/roadmap#958

@archisman-panigrahi
Copy link
Contributor

The action seems to be stuck for some reason https://github.com/johnfactotum/foliate/actions/runs/8918176680/job/24492363460?pr=1065

@jbicha
Copy link

jbicha commented May 2, 2024

Adding Ubuntu 24.04 CI is on Github's roadmap. I haven't seen an announcement that it is enabled yet.

@archisman-panigrahi
Copy link
Contributor

The GitHub action is working after 1. installing build dependencies, 2. fixing debhelper-compat version, and 3. checking out the submodules. Here is my code. archisman-panigrahi#1
@johnfactotum Should I send a PR?

@johnfactotum
Copy link
Owner Author

@archisman-panigrahi Yes, please. Thanks! Also I see there's a deprecation notice on actions/upload-artifact v2. Is that fixable by simply changing the version to v4?

@archisman-panigrahi
Copy link
Contributor

archisman-panigrahi commented Aug 28, 2024

Is that fixable by simply changing the version to v4?

Yes it got fixed this way.

Here is my PR #1383

* Update dependencies for github action for deb package

* debhelper-compat does not work with >=

* pull submodules

* Update upload-artifact version
@johnfactotum johnfactotum merged commit 8fe1364 into gtk4 Aug 28, 2024
5 checks passed
@johnfactotum johnfactotum deleted the github-action-deb branch August 28, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants