Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: migrate to Vue 3 & remove deprecated options #45

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

johannschopplich
Copy link
Owner

Work in progress.

Copy link

netlify bot commented Apr 22, 2024

Deploy Preview for kirbyup ready!

Name Link
🔨 Latest commit 8c8a728
🔍 Latest deploy log https://app.netlify.com/sites/kirbyup/deploys/66e143eb69021800087c8787
😎 Deploy Preview https://deploy-preview-45--kirbyup.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@johannschopplich
Copy link
Owner Author

@jonaskuske Hi there! The Kirby team (especially @distantnative) is working on the Vue 3 Panel update. Once it's ready and testable, would you please help in updating the HMR support? Much appreciated. 🙂

@jonaskuske
Copy link
Collaborator

Yes, will do :)

@jonaskuske
Copy link
Collaborator

@johannschopplich @distantnative

What's the right place to discuss Vue 3 migration plans? There are some aspects that directly affect HMR compat:

  • In Vue 2, Kirby externally modified/overwrote Vue component options. These modifications would get lost when Vue replaced the component instance with a fresh, updated component definition, so kirbyup-specific modifications of the HMR runtime were necessary. If component modification/extension could be handled differently for Vue 3, that would greatly simplify HMR support and limit edge cases
  • In Vue 2, the HMR runtime code was supplied through @vite/plugin-vue2, so it shipped with kirbyup. In Vue 3, the HMR runtime code is part of the main (development) Vue build. So Kirby would need to include both the production and the development build of Vue, and serve the dev build when kirbyup development is detected (index.dev.mjs exists, Kirby already checks for this)

@johannschopplich
Copy link
Owner Author

Good points, @jonaskuske!

In my opinion a separate thread or better a DM group would be appropriate. We could also talk in German when we're there. 😜

@distantnative
Copy link

Wanted to start a Discord chat, but @jonaskuske first has to accept my friend request :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants