-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error with let and conditional block in FX 44 #1
Open
oeekker
wants to merge
125
commits into
johan:master
Choose a base branch
from
oeekker:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…what findWindowsAndRun used to do.
Merge branch 'issue-5'
…g this and uninstall().
…ason to do any cleanup.
(cherry picked from commit 802d8cd)
Inlined options is almost ready - options.xul should be included
minor fix: typo in var name
commonjs style is almost ready - packages should be included
Fix for window unload issue r=@erikvold
Improved icons for a better mix with the new firefox ui
icon remix for new firefox ui
@@ -0,0 +1,21 @@ | |||
The MIT License |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat effort! I indeed haven't been more than forking this in case it'd turn out useful at some point and go lost, but I'm happy to merge an update, if Erik's cool with it. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if this is the main project, because the add-on itself point to Erik Vold, but I cannot find the repository there anymore. Anyway, I've applied this patch locally and I can use this add-on again in FX and TB 44…