Fixing problems with remote URL when using Maven Plugin #1614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| import org.apache.commons.lang.StringUtils; | ||
| import org.jsonschema2pojo.URLProtocol; | ||
|
|
||
| public class URLUtil { | ||
|
|
||
| private static final Set<URLProtocol> LOCAL_PROTOCOL = Arrays.stream(new URLProtocol[]{URLProtocol.NO_PROTOCOL, URLProtocol.FILE}).collect(Collectors.toSet()); |
There was a problem hiding this comment.
Can this just be replaced by Set.of?
There was a problem hiding this comment.
I'm afraid it can't since Set::of was introduced in Java 9 and current compiler configuration is:
Lines 213 to 223 in 34cc693
That being said it could be changed to = EnumSet.of(URLProtocol.NO_PROTOCOL, URLProtocol.FILE) with a small caveat - resulting set would be mutable (however that shouldn't be a problem since it's private and there are no methods returning it's reference.
There was a problem hiding this comment.
I changed the corresponding line. I am now using an EnumSet wrapped in an unmodifiable set.
There was a problem hiding this comment.
@joelittlejohn: Can it be merged now?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using remote URL's like an HTTP-Url as sourcePaths input. The URL's have been normalized to a file like notation. Afterwards the type generator was unable to resolve the remote file.