fix: use right ecj coordinates

see https://stackoverflow.com/questions/59416574/is-the-standalone-ecj-eclipse-java-compiler-package-no-longer-maintained
joelittlejohn · Aug 25, 2024 · f9226d4 · f9226d4
1 parent 87bd50f
commit f9226d4
Show file tree

Hide file tree

Showing 2 changed files with 36 additions and 8 deletions.
diff --git a/jsonschema2pojo-integration-tests/pom.xml b/jsonschema2pojo-integration-tests/pom.xml
@@ -1,4 +1,5 @@
-<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
 
     <modelVersion>4.0.0</modelVersion>
 
@@ -143,8 +144,9 @@
             <artifactId>moshi</artifactId>
         </dependency>
         <dependency>
-            <groupId>org.eclipse.jdt.core.compiler</groupId>
+            <groupId>org.eclipse.jdt</groupId>
             <artifactId>ecj</artifactId>
+            <scope>test</scope>
         </dependency>
         <dependency>
             <groupId>org.hamcrest</groupId>
@@ -183,8 +185,8 @@
             <artifactId>qdox</artifactId>
         </dependency>
         <dependency>
-          <groupId>org.skyscreamer</groupId>
-          <artifactId>jsonassert</artifactId>
+            <groupId>org.skyscreamer</groupId>
+            <artifactId>jsonassert</artifactId>
         </dependency>
         <dependency>
             <groupId>org.apache.geronimo.specs</groupId>

diff --git a/pom.xml b/pom.xml
@@ -293,19 +293,44 @@
         <profile>
             <id>jdk8</id>
             <activation>
-                <jdk>(,1.8]</jdk>
+                <jdk>(,1.9)</jdk>
             </activation>
             <properties>
                 <robolectric.version>3.8</robolectric.version>
+                <!-- https://bugs.eclipse.org/bugs/show_bug.cgi?id=574229 -->
+                <ecj.version>3.25.0</ecj.version>
             </properties>
         </profile>
         <profile>
             <id>jdk9</id>
             <activation>
-                <jdk>[1.9,)</jdk>
+                <jdk>[1.9,11)</jdk>
             </activation>
             <properties>
                 <robolectric.version>4.13</robolectric.version>
+                <!-- latest ecj build with 1.8 target, next 11 -->
+                <ecj.version>3.26.0</ecj.version>
+            </properties>
+        </profile>
+        <profile>
+            <id>jdk11</id>
+            <activation>
+                <jdk>[11,17)</jdk>
+            </activation>
+            <properties>
+                <robolectric.version>4.13</robolectric.version>
+                <!-- latest ecj build with 11 target, next 17 -->
+                <ecj.version>3.33.0</ecj.version>
+            </properties>
+        </profile>
+        <profile>
+            <id>jdk17</id>
+            <activation>
+                <jdk>[17,)</jdk>
+            </activation>
+            <properties>
+                <robolectric.version>4.13</robolectric.version>
+                <ecj.version>3.38.0</ecj.version>
             </properties>
         </profile>
     </profiles>
@@ -486,9 +511,10 @@
                 <version>3.3.4</version>
             </dependency>
             <dependency>
-                <groupId>org.eclipse.jdt.core.compiler</groupId>
+                <!-- https://github.com/eclipse-jdt/eclipse.jdt.core/issues/262 -->
+                <groupId>org.eclipse.jdt</groupId>
                 <artifactId>ecj</artifactId>
-                <version>4.6.1</version>
+                <version>${ecj.version}</version>
                 <scope>test</scope>
             </dependency>
             <dependency>