inital setup of dockerfile #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One note here Since there are env variables not set (DB/Mail server) that will cause a failure in the build. That is something we can probably work around (commenting it out) FYI |
joegiglio
reviewed
Apr 13, 2022
|
|
||
| ADD app.py . | ||
|
|
||
| COPY requirements.txt /tmp/requirements.txt |
There was a problem hiding this comment.
Is this right? It should go in /tmp?
|
I pulled this info from here
https://stackoverflow.com/questions/63922309/could-not-open-requirements-file-errno-2-no-such-file-or-directory-requirem
…On Wed, Apr 13, 2022 at 5:54 PM Joe G ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In Dockerfile
<#7 (comment)>:
> @@ -0,0 +1,11 @@
+FROM python:3.8
+
+#ENV key=value
+
+ADD app.py .
+
+COPY requirements.txt /tmp/requirements.txt
Is this right? It should go in /tmp?
—
Reply to this email directly, view it on GitHub
<#7 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AETAHNR4VCN2XO4SDTW55PDVE47AHANCNFSM5TL6ZJSA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
I have not seen anyone else do it like this in videos. I have no real
world experience with it though. Setting the working directory should be
enough, I would think.
On Thu, Apr 14, 2022 at 10:00 AM elitemagician ***@***.***>
wrote:
… I pulled this info from here
https://stackoverflow.com/questions/63922309/could-not-open-requirements-file-errno-2-no-such-file-or-directory-requirem
On Wed, Apr 13, 2022 at 5:54 PM Joe G ***@***.***> wrote:
> ***@***.**** commented on this pull request.
> ------------------------------
>
> In Dockerfile
> <#7 (comment)>:
>
> > @@ -0,0 +1,11 @@
> +FROM python:3.8
> +
> +#ENV key=value
> +
> +ADD app.py .
> +
> +COPY requirements.txt /tmp/requirements.txt
>
> Is this right? It should go in /tmp?
>
> —
> Reply to this email directly, view it on GitHub
> <
#7 (review)
>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/AETAHNR4VCN2XO4SDTW55PDVE47AHANCNFSM5TL6ZJSA
>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
—
Reply to this email directly, view it on GitHub
<#7 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOLSET4IE6TQBFQXPPZON53VFAQH5ANCNFSM5TL6ZJSA>
.
You are receiving this because you commented.Message ID:
***@***.***>
--
Joe Giglio
Engineering Manager
e: ***@***.*** | nomadhealth.com
<http://www.nomadhealth.com/>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker file and local build