Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add COLON Bind resource #851

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

roger-russel
Copy link

@roger-russel roger-russel commented Feb 22, 2023

This PR adds a new option to use a "colon" to bind variables.

I did it because the Go-Ora driver can use Named Queries and numbered colons.

But to use named queries, it is required to create objects in the database; in my case, it was impossible.

The alternative we used was to custom bind the driver to DOLLAR and used a regex to change it to numbered colons.
But with this PR now we will be able to use COLON as a bind type directly.

@dlsniper
Copy link
Collaborator

dlsniper commented Feb 1, 2024

Hello, @ardan-bkennedy, and I recently stepped in to help maintain this project.
We are sorting the opened issues and pull requests and would like to know if you still NEED this merged.
Thank you for your contribution.

@dlsniper dlsniper added the could merge The PR look safe enough to merge label Feb 1, 2024
@roger-russel-3thix
Copy link

roger-russel-3thix commented Oct 22, 2024

Hi @dlsniper and @ardan-bkennedy, yes, it is still needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
could merge The PR look safe enough to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants