-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for Pandora Thumbs Up/Down Problem #413
base: master
Are you sure you want to change the base?
Conversation
It was not obvious that the station and track was part of this uri still. Did you verify that? |
No, I went by the capture that he included. I just shortened the startswith string. It will fix the problem and still work with the original uri value if it too is still valid. I can give it a test in a few minutes. |
Tested. Works fine. Interesting though that my uri has the -http suffix. But it should work either way now. |
That seems odd. Are you sure you are testing against the same base version? Have you updated your fork with my latest changes (and latest sonos-discovery?) |
I have not for a month or two, so if you made a recent change to the uri, I don't have it deployed. I will update the next chance that I get. |
I see the problem. The URI has changed which affects how I was parsing. jishi, I'm only seeing one token instead of two. I'm not sure if the token following pndrradio: is the station token or the track token, and I need both. Can you let me know what the first token is and add back the other token? It appears that the values that I need are contained in the normal uri and get lost when you replace that uri with a high res uri in player.js. I need the m and x vales in the normal uri. Should we:
|
Don't Deprecate Pandora Thumbs! You just added it and its something I really want to work. |
I can't fix it without the information that I need from the URI as mentioned above |
Hi Jishi, Let me know if you have or will add the m and x values back into the uri and I'll fix this functionality. Otherwise we will need to deprecate the functionality. |
No description provided.