Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Pandora Thumbs Up/Down Problem #413

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix for Pandora Thumbs Up/Down Problem #413

wants to merge 1 commit into from

Conversation

jplourde5
Copy link
Contributor

No description provided.

@jishi
Copy link
Owner

jishi commented Dec 20, 2016

It was not obvious that the station and track was part of this uri still. Did you verify that?

@jplourde5
Copy link
Contributor Author

No, I went by the capture that he included. I just shortened the startswith string. It will fix the problem and still work with the original uri value if it too is still valid. I can give it a test in a few minutes.

@jplourde5
Copy link
Contributor Author

Tested. Works fine. Interesting though that my uri has the -http suffix. But it should work either way now.

@jishi
Copy link
Owner

jishi commented Dec 21, 2016

That seems odd. Are you sure you are testing against the same base version? Have you updated your fork with my latest changes (and latest sonos-discovery?)

@jplourde5
Copy link
Contributor Author

I have not for a month or two, so if you made a recent change to the uri, I don't have it deployed. I will update the next chance that I get.

@jplourde5
Copy link
Contributor Author

jplourde5 commented Jan 3, 2017

I see the problem. The URI has changed which affects how I was parsing.

jishi, I'm only seeing one token instead of two. I'm not sure if the token following pndrradio: is the station token or the track token, and I need both. Can you let me know what the first token is and add back the other token?

It appears that the values that I need are contained in the normal uri and get lost when you replace that uri with a high res uri in player.js. I need the m and x vales in the normal uri. Should we:

  1. Preserve tha native uri as a separate added track parameter?
  2. Add parameters for the m and x values to track and capture them for Pandora types?
  3. Include the m and x values in the high res uri?
  4. Pass them in some other way?
  5. Deprecate Pandora Thumbs?

@NovaGL
Copy link

NovaGL commented Mar 24, 2017

Don't Deprecate Pandora Thumbs! You just added it and its something I really want to work.

@jplourde5
Copy link
Contributor Author

I can't fix it without the information that I need from the URI as mentioned above

@jplourde5
Copy link
Contributor Author

Hi Jishi, Let me know if you have or will add the m and x values back into the uri and I'll fix this functionality. Otherwise we will need to deprecate the functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants