Skip to content

Commit

Permalink
Release v6.22.0
Browse files Browse the repository at this point in the history
  • Loading branch information
@pioug
pioug committed Jul 3, 2021
1 parent b1b0022 commit 75c59da
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion package-lock.json
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "jira-client",
"version": "6.21.1",
"version": "6.22.0",
"description": "Wrapper for the JIRA API",
"author": "Steven Surowiec <[email protected]>",
"contributors": [
Expand Down

7 comments on commit 75c59da

@genio
Copy link

@genio genio commented on 75c59da Jul 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this got published to NPM. Can you check, please?

@pioug
Copy link
Contributor Author

@pioug pioug commented on 75c59da Jul 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@genio Oh indeed, it's published now https://www.npmjs.com/package/jira-client/v/6.22.0 Thank you!

@WyrmxD
Copy link

@WyrmxD WyrmxD commented on 75c59da Oct 15, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I am finding several inconsistencies between the code in the release 6.22.0 and the one is downloaded using yarn add jira-client.

For example:

value: function getIssuesForBacklog(boardId) {

has a different signature

getIssuesForBacklog(boardId, startAt = 0, maxResults = 50, jql, validateQuery = true, fields) {

The version I got described in the package.json seems to be the right one:

"jira-client": "^6.22.0"

Many thx!

@pioug
Copy link
Contributor Author

@pioug pioug commented on 75c59da Oct 15, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WyrmxD Can you test v6.23.0? I probably did a mistake before, I used npm run release minor this time.

@WyrmxD
Copy link

@WyrmxD WyrmxD commented on 75c59da Oct 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @pioug, thanks for the quick answer.

Still the same issue: version of the package has increased to 6.23.0 but the code is the old one.

package.json
{ "name": "jira-client", "version": "6.23.0",

lib/jira.js
key: "getIssuesForBacklog", value: function getIssuesForBacklog(boardId) {

@pioug
Copy link
Contributor Author

@pioug pioug commented on 75c59da Oct 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WyrmxD I don't think there is any issue with the release. It's simply how Babel transpiled the code:

{
    key: "getIssuesForBacklog",
    value: function getIssuesForBacklog(boardId) {
      var startAt = arguments.length > 1 && arguments[1] !== undefined ? arguments[1] : 0;
      var maxResults = arguments.length > 2 && arguments[2] !== undefined ? arguments[2] : 50;
      var jql = arguments.length > 3 ? arguments[3] : undefined;
      var validateQuery = arguments.length > 4 && arguments[4] !== undefined ? arguments[4] : true;
      var fields = arguments.length > 5 ? arguments[5] : undefined;
      return this.doRequest(this.makeRequestHeader(this.makeAgileUri({
        pathname: "/board/".concat(boardId, "/backlog"),
        query: {
          startAt: startAt,
          maxResults: maxResults,
          jql: jql,
          validateQuery: validateQuery,
          fields: fields
        }
      })));
    }

@WyrmxD
Copy link

@WyrmxD WyrmxD commented on 75c59da Oct 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @pioug, you are completely right sorry about all the confusion.

My problem was considering getEpics and getIssuesForBacklog returning the same, which is not true and my code was failing.
The first one is returning isLast as part of the chunk of epics while the second is returning total, my problem was pagination.

Sorry again and many thanks for the time answering my questions and maintaining the code :)

Please sign in to comment.