Feature: Aggregated logs in single file #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimhester
reviewed
Oct 6, 2022
| @@ -56,7 +56,7 @@ | |||
| # configuration, the base under which the directory histories are stored | |||
| #------------------------------------------------------------------------------- | |||
|
|
|||
| [[ -z $HISTORY_BASE ]] && HISTORY_BASE="$HOME/.directory_history" | |||
| [[ -z $HISTORY_BASE ]] && HISTORY_BASE="$HOME/.config/directory_history" | |||
There was a problem hiding this comment.
If we want to change the default for history base I think it needs to be discussed in a separate PR.
It should also probably use $XDG_CONFIG_HOME with a fallback to $HOME/.config if XDG_CONFIG_HOME is not set.
There was a problem hiding this comment.
I can revert that HISTORY_BASE change.
Let me know if you have more remarks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It lets to use one history file for multiple directories by setting
PER_DIRECTORY_AGGREGATED_PATHenv (usedirenvto set that in your directories accordingly)