-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update dependency @sveltejs/kit to v2.8.3 [security] #505
Conversation
Deploying svelte-hydrated with Cloudflare Pages
|
Wraith CI 👻 Retry RequestCheck the box to re-trigger CI.
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@sveltejs/[email protected] |
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
This PR contains the following updates:
2.5.24
->2.8.3
GitHub Vulnerability Alerts
GHSA-mh2x-fcqh-fmqv
Summary
The static error.html template for errors contains placeholders that are replaced without escaping the content first.
Details
From https://kit.svelte.dev/docs/errors:
This leads to possible injection if an app explicitly creates an error with a message that contains user controlled content that ends up being something like this inside a server handle function:
Uncaught errors cannot be exploited like this, as they always render the message "Internal error".
Escaping the message string in the function that creates the html output can be done to improve safety for applications that are using custom errors on the server.
PoC
None provided
Impact
Only applications where user provided input is used in the
Error
message will be vulnerable, so the vast majority of applications will not be vulnerableGHSA-rjjv-87mx-6x3h
Summary
"Unsanitized input from the request URL flows into
end
, where it is used to render an HTML page returned to the user. This may result in a Cross-Site Scripting attack (XSS)."Details
Source of potentially tainted data is in
packages/kit/src/exports/vite/dev/index.js
, line 437. This potentially tainted data is passed through a number of steps (which I could detail if you'd like) all the way down to line 91 inpackages/kit/src/exports/vite/utils.js
, which performs an operation that Snyk believes an attacker shouldn't be allowed to manipulate.Another source of potentially tainted data (according to Snyk) comes from
packages/kit/src/exports/vite/utils.js
, line 30, col 30 (i.e., theurl
property ofreq
). This potentially tainted data is passed through a number of steps (which I could detail if you'd like) all the way down line 91 inpackages/kit/src/exports/vite/utils.js
, which performs an operation that Snyk believes an attacker shouldn't be allowed to manipulate.PoC
Not provided
Impact
Little to none. The Vite development is not exposed to the network by default. And even if someone were able to trick a developer into executing an XSS against themselves, a development database should not have any sensitive data.
Release Notes
sveltejs/kit (@sveltejs/kit)
v2.8.3
Compare Source
Patch Changes
fix: ensure error messages are escaped (#13050)
fix: escape values included in dev 404 page (#13039)
v2.8.2
Compare Source
Patch Changes
fix: prevent duplicate fetch request when using Request with load function's fetch (#13023)
fix: do not override default cookie decoder to allow users to override the
cookie
library version (#13037)v2.8.1
Compare Source
Patch Changes
fix: only add nonce to
script-src-elem
,style-src-attr
andstyle-src-elem
CSP directives whenunsafe-inline
is not present (#11613)fix: support HTTP/2 in dev and production. Revert the changes from #12907 to downgrade HTTP/2 to TLS as now being unnecessary (#12989)
v2.8.0
Compare Source
Minor Changes
ActionFailure
objects (#12878)v2.7.7
Compare Source
Patch Changes
v2.7.6
Compare Source
Patch Changes
v2.7.5
Compare Source
Patch Changes
fix: warn on invalid cookie name characters (#12806)
fix: when using
@vitejs/plugin-basic-ssl
, set a no-op proxy config to downgrade from HTTP/2 to TLS sinceundici
does not yet enable HTTP/2 by default (#12907)v2.7.4
Compare Source
Patch Changes
fix: ensure element is focused after subsequent clicks of the same hash link (#12866)
fix: avoid preload if event default was prevented for
touchstart
andmousedown
events (#12887)fix: avoid reloading behaviour for hash links with data-sveltekit-reload if the hash is on the same page (#12866)
v2.7.3
Compare Source
Patch Changes
fix: include importer in illegal import error message (#12820)
fix: don't try reading assets directly that aren't present (#12876)
fix: decode non-latin characters when previewing prerendered pages (#12874)
fix: better error message when a
Result
is returned from a form action (#12829)docs: update URLs for new svelte.dev site (#12857)
v2.7.2
Compare Source
Patch Changes
v2.7.1
Compare Source
Patch Changes
chore: upgrade to sirv 3.0 (#12796)
fix: warn when form action responses are lost because SSR is off (#12063)
v2.7.0
Compare Source
Minor Changes
Patch Changes
fix: correctly handle relative paths when fetching assets on the server (#12113)
fix: decode non ASCII anchor hashes when scrolling into view (#12699)
fix: page response missing CSP and Link headers when return promise in
load
(#12418)v2.6.4
Compare Source
Patch Changes
fix: only preload links that have a different URL than the current page (#12773)
fix: revert change to replace version in generateBundle (#12779)
fix: catch stack trace fixing errors thrown in web containers (#12775)
fix: use absolute links in JSDoc comments (#12772)
v2.6.3
Compare Source
Patch Changes
fix: ensure a changing
version
doesn't affect the hashes for chunks without any actual code changes (#12700)fix: prevent crash when logging URL search params in a server load function (#12763)
chore: revert update dependency cookie to ^0.7.0 (#12767)
v2.6.2
Compare Source
Patch Changes
v2.6.1
Compare Source
Patch Changes
v2.6.0
Compare Source
Minor Changes
load
functions (#12716)Patch Changes
<form target="_blank">
and ` submissions (#11936)v2.5.28
Compare Source
Patch Changes
node:process
instead of using globals (#12641)v2.5.27
Compare Source
Patch Changes
fix: asynchronously instantiate components when using Svelte 5 (#12613)
fix: use
{@​render ...}
tag when generating default fallback page for svelte 5 apps (#12653)fix: emulate
event.platform
even when the route does not exist (#12513)v2.5.26
Compare Source
Patch Changes
v2.5.25
Compare Source
Patch Changes
6056ba30e29ac5747c356fbf1a42dd71f2c4aa1f
)Configuration
📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.