매치 상세내역 firebase 연동 #39
Conversation
|
Visit the preview URL for this PR (updated for commit 4f6b874): https://dailyfield-a845d--pr39-getmatch-st2uwog8.web.app (expires Sun, 07 Feb 2021 13:16:21 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
src/components/MatchDetail.tsx
Outdated
| const [match, setMatch] = useState<Match | null>(null); | ||
|
|
||
| const getMatch = useCallback(async () => { | ||
| const matchId = history.location.pathname.split("/")[2]; |
There was a problem hiding this comment.
컴포넌트 안에서 history location 읽으면 말끔하지 않아. useParameter써봐.
There was a problem hiding this comment.
useParameter 쓰면 useCallback 필요 없나봐
src/components/MatchDetail.tsx
Outdated
|
|
||
| useEffect(() => { | ||
| getMatch(); | ||
| }, [getMatch]); |
There was a problem hiding this comment.
[getMatch] 맞지 않을것 같아. 왜냐면 getMatch이 함수야. 값이 안 바꿔. 뭘 필요해?
https://reactjs.org/docs/hooks-reference.html#conditionally-firing-an-effect
There was a problem hiding this comment.
src/components/MatchDetail.tsx
Line 17:6: React Hook useEffect has a missing dependency: 'getMatch'. Either include it or remove the dependency array react-hooks/exhaustive-deps
때문에 deploy 자꾸 실패해... ㅠㅠ
| }), | ||
| }); | ||
| }); | ||
|
|
||
| test("renders MatchDetail", async () => { | ||
| render(<MatchDetail />); |
There was a problem hiding this comment.
가짜 useParameter 값을 줘야해. 그리고 await db.collection("matches").doc(matchId).get();의 matchId 확인 해줘.
expect(useParameter의 준 id).toBe(.doc이 쓴matchId)There was a problem hiding this comment.
그런데 그 테스트 만들기 너무 어려우면 나중에 #43 처리 할때 해도 돼.
src/components/MatchDetail.tsx
Outdated
|
|
||
| useEffect(() => { | ||
| getMatch(); | ||
| }, [id]); |
There was a problem hiding this comment.
응. getMatch을 useEffect안에 옮겨줘. 문서 다시 한번 읽어봐
usually you’ll want to declare functions needed by an effect inside of it.
There was a problem hiding this comment.
useEffect 안에 옮겨서 해결했는데 나중에 한번더 설명해줘! ㅎㅎ
matchDetail에서 dummy data -> firebase 실제 데이터 연동으로 변경