입력 받은 패스워드와 저장 된 패스워드를 비교하는 메서드를 리팩터링을 하라 #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
password 변수명은 추상적으로 표현되어 있어서 rawPassword즉 암호화 되지 않은 패스워드로 사용하는게 좀 더 명확하다고 판단이 되어 수정했습니다 comparedPassword 메서드의 파라미터에서 Member는 어떤 값을 비교하는지 의도를 알아내기가 어려워서 Member.password가 더 분명함으로 수정했습니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
password 변수명은 추상적으로 표현되어 있어서 rawPassword즉 암호화 되지 않은 패스워드로 사용하는게 좀 더 명확하다고 판단이 되어 수정했습니다 comparedPassword 메서드의 파라미터에서 Member는 어떤 값을 비교하는지 의도를 알아내기가 어려워서 Member.password가 더 분명함으로 수정했습니다