Merge pull request #83 from jihwooon/issue-54

form-data 요청 시 string 타입을 number타입으로 형변환을 하라
jihwooon · Oct 23, 2023 · fabc792 · fabc792
2 parents be42478 + e3345cc
commit fabc792
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 19 deletions.
diff --git a/server/src/items/application/item.creater.ts b/server/src/items/application/item.creater.ts
@@ -14,21 +14,23 @@ export class ItemCreater {
   ) {}
 
   async registerItem(items: Item, email: string, files: Express.Multer.File[]): Promise<number> {
+    const { itemName, itemDetail, price, stockNumber, itemSellStatus } = items
+
     const member = await this.memberRepository.findByEmail(email)
     if (!member) {
       throw new MemberNotFoundException('회원 정보를 찾을 수 없습니다')
     }
 
-    const savedItem = new Item({
-      itemName: items.itemName,
-      itemDetail: items.itemDetail,
-      price: items.price,
-      stockNumber: items.stockNumber,
-      sellStatus: items.itemSellStatus,
-      member: member,
-    })
-
-    const savedId = await this.itemRepository.save(savedItem)
+    const savedId = await this.itemRepository.save(
+      new Item({
+        itemName: itemName,
+        itemDetail: itemDetail,
+        price: price,
+        stockNumber: stockNumber,
+        sellStatus: itemSellStatus,
+        member: member,
+      }),
+    )
     await this.itemImageService.saveItemImages(savedId, files)
 
     if (!savedId) {

diff --git a/server/src/items/dto/save-item.dto.ts b/server/src/items/dto/save-item.dto.ts
@@ -11,11 +11,9 @@ export class CreateItemRequest {
   itemDetail: string
 
   @IsNotEmpty({ message: '가격은 필수 입력 값입니다.' })
-  @IsNumber()
   price: number
 
   @IsNotEmpty({ message: '재고는 필수 입력 값입니다.' })
-  @IsNumber()
   stockNumber: number
 
   @IsEnum({ sellStatus: ItemStatusEnum.SELL })

diff --git a/server/src/items/web/item-create.controller.ts b/server/src/items/web/item-create.controller.ts
@@ -29,8 +29,8 @@ export class ItemCreateController {
       new Item({
         itemName: itemName,
         itemDetail: itemDetail,
-        price: price,
-        stockNumber: stockNumber,
+        price: Number(price),
+        stockNumber: Number(stockNumber),
         sellStatus: sellStatus,
       }),
       email,

diff --git a/server/test/item-create.e2e-spec.ts b/server/test/item-create.e2e-spec.ts
@@ -313,7 +313,7 @@ describe('ItemCreateController (e2e)', () => {
         expect(status).toEqual(400)
         expect(body).toEqual({
           error: 'Bad Request',
-          message: ['price must be a number conforming to the specified constraints', '가격은 필수 입력 값입니다.'],
+          message: ['가격은 필수 입력 값입니다.'],
           statusCode: 400,
         })
       })
@@ -337,10 +337,7 @@ describe('ItemCreateController (e2e)', () => {
         expect(status).toEqual(400)
         expect(body).toEqual({
           error: 'Bad Request',
-          message: [
-            'stockNumber must be a number conforming to the specified constraints',
-            '재고는 필수 입력 값입니다.',
-          ],
+          message: ['재고는 필수 입력 값입니다.'],
           statusCode: 400,
         })
       })