Merge pull request #103 from jihwooon/issue-68

item-image를 리팩터링을 하라
jihwooon · Dec 18, 2023 · b934cc9 · b934cc9
2 parents 5f881f3 + da52035
commit b934cc9
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 7 deletions.
diff --git a/server/src/item-images/application/item-image.creater.ts b/server/src/item-images/application/item-image.creater.ts
@@ -13,15 +13,16 @@ export class ItemImageCreater {
   ) {}
 
   async saveItemImages(itemId: number, @UploadedFiles() files: Express.Multer.File[]) {
-    if (Array.isArray(files) && files.length === 0) {
+    if (!files || files.length === 0) {
       throw new FileIsNotEmpty('파일은 필수 입력 값입니다')
     }
 
-    files.map((file, i) => {
-      const isRepresentImage: boolean = i === 0
-
-      this.saveItemImage(itemId, { ...file }, isRepresentImage)
-    })
+    await Promise.all(
+      files.map((file, i) => {
+        const isRepresentImage: boolean = i === 0
+        this.saveItemImage(itemId, { ...file }, isRepresentImage)
+      }),
+    )
   }
 
   async saveItemImage(itemId: number, @UploadedFiles() file: Express.Multer.File, isRepresentImage) {

diff --git a/server/src/item-images/application/item-image.updater.ts b/server/src/item-images/application/item-image.updater.ts
@@ -13,7 +13,7 @@ export class ItemImageUpdater {
     const { id } = items
 
     const itemImages = await this.itemImageRepository.findByItemOrderByItemImageIdAsc(id)
-    if (Array.isArray(itemImages) && itemImages.length === 0) {
+    if (!itemImages || itemImages.length === 0) {
       throw new ItemImageNotFoundException(`${id}에 해당하는 이미지를 찾을 수 없습니다.`)
     }