-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lee Ho Seong #10
Open
leon-808
wants to merge
21
commits into
jihwooon:main
Choose a base branch
from
leon-808:leehoseong
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Lee Ho Seong #10
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
d9bee02
Initial commit
jihwooon bd6746e
update, draw 함수 리팩터링
leon-808 f964ca5
ch01 예제 세가지 풀이와 eslint 따옴표 해결
leon-808 d6e7cb1
sum.test.ts 풀이
leon-808 87b1262
Input 인터페이스, 클래스로의 코드 이관
leon-808 f268a65
신호등 기능 interface, class 로의 코드 이관 및 테스트
leon-808 78ab05a
타일 Interface, Class 로의 코드 이관 및 에러
leon-808 21c83cb
Map 변수, 생성 함수로 에러 해결 및 PR 제언 토대로 수정
leon-808 207897b
Remove 메서드 전문화, colorOfTile 클래스로 코드 이관
leon-808 ab5ae4c
if 문 추가 이관을 통해 color 를 draw 함수로 변경
leon-808 f223e7b
moveHorizontal, Vertical 인라인화
leon-808 6733d98
stony, boxy 메서드 추가 및 stone, box 클래스 리팩터링
leon-808 a8e4e99
.prettierignore 파일 무시
leon-808 44826c2
조건문에서 부수적인 동작 분리
leon-808 755dc54
updateTile 인라인화와 불필요한 코드 정리
leon-808 5a9d2f1
FallStrategy 클래스로 코드 이관 및 메소드 통합
leon-808 6068dff
Array.ts 전략 패턴 적용
leon-808 20ecf29
Processor 인터페이스를 생성해 유사한 클래스 통합
leon-808 f50acda
remove 함수를 하나로 통합하기 위한 인터페이스 도입
leon-808 0983348
Key 와 Lock 클래스의 통합
leon-808 7474c00
전략 패턴 적용을 위한 KeyConfiguration 클래스 도입
leon-808 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| .idea | ||
| .vscode | ||
| .prettierignore | ||
| node_modules | ||
| dist | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gitingore 파일에
.prettierignore를 추가하셨네요. 현재 커밋에서는 이 설정이 어떤 의도로 추가 되어 있는지를 알 수가 없습니다. 해당 파일을 따로 커밋을 두고 의도를 설명하는 편이 좋을 것 같습니다.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아 원자적으로 커밋을 나눠야 하나 보네요.
.prettierignore 파일은 이 프로젝트 전반에 prettier 가 작동하지 않도록 하는 파일입니다.
reset 해서 커밋을 나눠보도록 하겠습니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
해당 파일만 따로 커밋을 잘 나누셨네요~! 이 부분을 어떻게 해결했는지 블로그나 글로 작성하셔도 좋을 것 같습니다~!