Implemented redirect via HTML meta refresh tag support #1086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for this. Can you add some integration tests, and unit tests for the meta tag -> url parser? I think this only works if the content value is like Also, this will NPE if there is no content attribute and if there is no semi colon in the attribute. Also can you squash this PR. |
|
@jhy thanks for pointing everything out, I made some fixes. Not sure how to properly unit test this, due to the fact that the logic is encapsulated, though I did write the integration test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issue (#371). As @jhy suggested, this feature is optional and disabled by default. Enable it using
Connection.followMetaRedirects(true)