Skip to content

Commit

Permalink
Fix #3830
Browse files Browse the repository at this point in the history
  • Loading branch information
@jgthms
jgthms committed Jun 23, 2024
1 parent 1ad4cb2 commit 74c01f4
Show file tree
Hide file tree
Showing 20 changed files with 62 additions and 69 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
### Bug fixes

- Fix #3824: ability to override `$scheme-h`, `$scheme-s`, `$dark-l` and `$light-l` Sass variables
- Fix #3830: add remaining logical properties

## 1.0.1

Expand Down
16 changes: 8 additions & 8 deletions css/bulma.css
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6240,14 +6240,14 @@ button.tag:active,
.field.has-addons .control:first-child:not(:only-child) .button,
.field.has-addons .control:first-child:not(:only-child) .input,
.field.has-addons .control:first-child:not(:only-child) .select select {
border-bottom-right-radius: 0;
border-top-right-radius: 0;
border-start-end-radius: 0;
border-end-end-radius: 0;
}
.field.has-addons .control:last-child:not(:only-child) .button,
.field.has-addons .control:last-child:not(:only-child) .input,
.field.has-addons .control:last-child:not(:only-child) .select select {
border-bottom-left-radius: 0;
border-top-left-radius: 0;
border-start-start-radius: 0;
border-end-start-radius: 0;
}
.field.has-addons .control .button:not([disabled]):hover, .field.has-addons .control .button:not([disabled]).is-hovered,
.field.has-addons .control .input:not([disabled]):hover,
Expand Down Expand Up @@ -7763,8 +7763,8 @@ a.navbar-item.is-active, a.navbar-item.is-selected,
}
.navbar-dropdown {
background-color: var(--bulma-navbar-dropdown-background-color);
border-bottom-left-radius: var(--bulma-navbar-dropdown-radius);
border-bottom-right-radius: var(--bulma-navbar-dropdown-radius);
border-end-start-radius: var(--bulma-navbar-dropdown-radius);
border-end-end-radius: var(--bulma-navbar-dropdown-radius);
border-top-color: var(--bulma-navbar-dropdown-border-color);
border-top-style: var(--bulma-navbar-dropdown-border-style);
border-top-width: var(--bulma-navbar-dropdown-border-width);
Expand Down Expand Up @@ -8250,8 +8250,8 @@ a.navbar-item.is-active, a.navbar-item.is-selected,
color: hsl(var(--bulma-panel-h), var(--bulma-panel-s), var(--bulma-panel-color-l));
}
.panel-block:last-child {
border-bottom-left-radius: var(--bulma-panel-radius);
border-bottom-right-radius: var(--bulma-panel-radius);
border-end-start-radius: var(--bulma-panel-radius);
border-end-end-radius: var(--bulma-panel-radius);
}

a.panel-block,
Expand Down
2 changes: 1 addition & 1 deletion css/bulma.css.map
View file

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion css/bulma.min.css
View file

Large diffs are not rendered by default.

16 changes: 8 additions & 8 deletions css/versions/bulma-no-dark-mode.css
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3437,14 +3437,14 @@ button.tag:active,
.field.has-addons .control:first-child:not(:only-child) .button,
.field.has-addons .control:first-child:not(:only-child) .input,
.field.has-addons .control:first-child:not(:only-child) .select select {
border-bottom-right-radius: 0;
border-top-right-radius: 0;
border-start-end-radius: 0;
border-end-end-radius: 0;
}
.field.has-addons .control:last-child:not(:only-child) .button,
.field.has-addons .control:last-child:not(:only-child) .input,
.field.has-addons .control:last-child:not(:only-child) .select select {
border-bottom-left-radius: 0;
border-top-left-radius: 0;
border-start-start-radius: 0;
border-end-start-radius: 0;
}
.field.has-addons .control .button:not([disabled]):hover, .field.has-addons .control .button:not([disabled]).is-hovered,
.field.has-addons .control .input:not([disabled]):hover,
Expand Down Expand Up @@ -4960,8 +4960,8 @@ a.navbar-item.is-active, a.navbar-item.is-selected,
}
.navbar-dropdown {
background-color: var(--bulma-navbar-dropdown-background-color);
border-bottom-left-radius: var(--bulma-navbar-dropdown-radius);
border-bottom-right-radius: var(--bulma-navbar-dropdown-radius);
border-end-start-radius: var(--bulma-navbar-dropdown-radius);
border-end-end-radius: var(--bulma-navbar-dropdown-radius);
border-top-color: var(--bulma-navbar-dropdown-border-color);
border-top-style: var(--bulma-navbar-dropdown-border-style);
border-top-width: var(--bulma-navbar-dropdown-border-width);
Expand Down Expand Up @@ -5447,8 +5447,8 @@ a.navbar-item.is-active, a.navbar-item.is-selected,
color: hsl(var(--bulma-panel-h), var(--bulma-panel-s), var(--bulma-panel-color-l));
}
.panel-block:last-child {
border-bottom-left-radius: var(--bulma-panel-radius);
border-bottom-right-radius: var(--bulma-panel-radius);
border-end-start-radius: var(--bulma-panel-radius);
border-end-end-radius: var(--bulma-panel-radius);
}

a.panel-block,
Expand Down
2 changes: 1 addition & 1 deletion css/versions/bulma-no-dark-mode.css.map
View file

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion css/versions/bulma-no-dark-mode.min.css
View file

Large diffs are not rendered by default.

16 changes: 8 additions & 8 deletions css/versions/bulma-no-helpers-prefixed.css
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion css/versions/bulma-no-helpers-prefixed.css.map
View file

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion css/versions/bulma-no-helpers-prefixed.min.css
View file

Large diffs are not rendered by default.

16 changes: 8 additions & 8 deletions css/versions/bulma-no-helpers.css
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion css/versions/bulma-no-helpers.css.map
View file

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion css/versions/bulma-no-helpers.min.css
View file

Large diffs are not rendered by default.

16 changes: 8 additions & 8 deletions css/versions/bulma-prefixed.min.css
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6240,14 +6240,14 @@ button.bulma-tag:active,
.bulma-field.bulma-has-addons .bulma-control:first-child:not(:only-child) .bulma-button,
.bulma-field.bulma-has-addons .bulma-control:first-child:not(:only-child) .bulma-input,
.bulma-field.bulma-has-addons .bulma-control:first-child:not(:only-child) .bulma-select select {
border-bottom-right-radius: 0;
border-top-right-radius: 0;
border-start-end-radius: 0;
border-end-end-radius: 0;
}
.bulma-field.bulma-has-addons .bulma-control:last-child:not(:only-child) .bulma-button,
.bulma-field.bulma-has-addons .bulma-control:last-child:not(:only-child) .bulma-input,
.bulma-field.bulma-has-addons .bulma-control:last-child:not(:only-child) .bulma-select select {
border-bottom-left-radius: 0;
border-top-left-radius: 0;
border-start-start-radius: 0;
border-end-start-radius: 0;
}
.bulma-field.bulma-has-addons .bulma-control .bulma-button:not([disabled]):hover, .bulma-field.bulma-has-addons .bulma-control .bulma-button:not([disabled]).bulma-is-hovered,
.bulma-field.bulma-has-addons .bulma-control .bulma-input:not([disabled]):hover,
Expand Down Expand Up @@ -7763,8 +7763,8 @@ a.bulma-navbar-item.bulma-is-active, a.bulma-navbar-item.bulma-is-selected,
}
.bulma-navbar-dropdown {
background-color: var(--bulma-navbar-dropdown-background-color);
border-bottom-left-radius: var(--bulma-navbar-dropdown-radius);
border-bottom-right-radius: var(--bulma-navbar-dropdown-radius);
border-end-start-radius: var(--bulma-navbar-dropdown-radius);
border-end-end-radius: var(--bulma-navbar-dropdown-radius);
border-top-color: var(--bulma-navbar-dropdown-border-color);
border-top-style: var(--bulma-navbar-dropdown-border-style);
border-top-width: var(--bulma-navbar-dropdown-border-width);
Expand Down Expand Up @@ -8250,8 +8250,8 @@ a.bulma-navbar-item.bulma-is-active, a.bulma-navbar-item.bulma-is-selected,
color: hsl(var(--bulma-panel-h), var(--bulma-panel-s), var(--bulma-panel-color-l));
}
.bulma-panel-block:last-child {
border-bottom-left-radius: var(--bulma-panel-radius);
border-bottom-right-radius: var(--bulma-panel-radius);
border-end-start-radius: var(--bulma-panel-radius);
border-end-end-radius: var(--bulma-panel-radius);
}

a.bulma-panel-block,
Expand Down
2 changes: 1 addition & 1 deletion css/versions/bulma-prefixed.min.css.map
View file

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion css/versions/bulma-prefixed.min.min.css
View file

Large diffs are not rendered by default.

10 changes: 3 additions & 7 deletions docs/documentation/start/installation.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -71,13 +71,9 @@
item_b=jsdelivr_b
%}

<p class="block">The <strong>RTL version</strong> is also available:</p>

{%
include docs/components/tabs.html
button_a="CSS @import" button_b="HTML <link />" item_a=jsdelivr_rtl_a
item_b=jsdelivr_rtl_b
%}
<p class="block">
Since the release of v1, the main version also works in <strong>RTL contexts</strong>, thanks to the use of <a href="https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_logical_properties_and_values">logical properties</a>. As a result, no separate RTL version of Bulma is developed anymore.
</p>

<p class="block">
Bulma is also available via
Expand Down
4 changes: 2 additions & 2 deletions sass/components/navbar.scss
View file
Original file line number Diff line number Diff line change
Expand Up @@ -650,8 +650,8 @@ a.#{iv.$class-prefix}navbar-item,

.#{iv.$class-prefix}navbar-dropdown {
background-color: cv.getVar("navbar-dropdown-background-color");
border-bottom-left-radius: cv.getVar("navbar-dropdown-radius");
border-bottom-right-radius: cv.getVar("navbar-dropdown-radius");
border-end-start-radius: cv.getVar("navbar-dropdown-radius");
border-end-end-radius: cv.getVar("navbar-dropdown-radius");
border-top-color: cv.getVar("navbar-dropdown-border-color");
border-top-style: cv.getVar("navbar-dropdown-border-style");
border-top-width: cv.getVar("navbar-dropdown-border-width");
Expand Down
4 changes: 2 additions & 2 deletions sass/components/panel.scss
View file
Original file line number Diff line number Diff line change
Expand Up @@ -192,8 +192,8 @@ $panel-colors: dv.$colors !default;
}

&:last-child {
border-bottom-left-radius: cv.getVar("panel-radius");
border-bottom-right-radius: cv.getVar("panel-radius");
border-end-start-radius: cv.getVar("panel-radius");
border-end-end-radius: cv.getVar("panel-radius");
}
}

Expand Down
12 changes: 4 additions & 8 deletions sass/form/tools.scss
View file
Original file line number Diff line number Diff line change
Expand Up @@ -85,21 +85,17 @@ $label-colors: shared.$form-colors !default;
.#{iv.$class-prefix}button,
.#{iv.$class-prefix}input,
.#{iv.$class-prefix}select select {
// @include ltr {
border-bottom-right-radius: 0;
border-top-right-radius: 0;
// }
border-start-end-radius: 0;
border-end-end-radius: 0;
}
}

&:last-child:not(:only-child) {
.#{iv.$class-prefix}button,
.#{iv.$class-prefix}input,
.#{iv.$class-prefix}select select {
// @include ltr {
border-bottom-left-radius: 0;
border-top-left-radius: 0;
// }
border-start-start-radius: 0;
border-end-start-radius: 0;
}
}

Expand Down

0 comments on commit 74c01f4

Please sign in to comment.