Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce isHeaderPngAccessible() timeout #235

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

EyalDelarea
Copy link
Contributor

@EyalDelarea EyalDelarea commented Dec 15, 2024

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • I used npm run format for formatting the code before submitting the pull request.

To optimize performance, this PR modifies the process for checking internet availability for the header image. Instead of performing the check repeatedly, the availability is now verified only once, with a reduced timeout to minimize delays.

@EyalDelarea EyalDelarea added the safe to test Approve running integration tests on a pull request label Dec 16, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 16, 2024
@EyalDelarea EyalDelarea added improvement Automatically generated release notes safe to test Approve running integration tests on a pull request labels Dec 16, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 16, 2024
Copy link

@ccano2011 ccano2011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a much better option, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make isHeaderPngAccessible() toggleable for offline environments
3 participants