Fix warnings for Xcode 12, when used from SPM #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rt building for watchOS.
|
Hi, I also get the enum warning you fixed and some other warnings for public modifer: /Pods/Dwifft/Dwifft/Dwifft.swift:312:5: 'public' modifier is redundant for instance method declared in a public extension Maybe you can add those too? And do you know what's needed to get the PR merged and deployed in a new version? |
|
It's up to maintainer @jflinter I guess. As for the warnings you are mentioning, they are already fixed on master branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SPM in Xcode 12 bumps minimum iOS deployment target to iOS 9, which produces warnings when trying to use Dwifft.
This PR fixes that by deleting minimum supported platforms from Package.swift. Please note, that macOS platform stays, because Dwifft minimum requirement for MacOS is higher than SwiftPM minimum deployment target.
I've also fixed couple new warnings from Swift compiler and enabled building for watchOS.