Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update the return type of createCacheKey #15159

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Conversation

latin-1
Copy link
Contributor

@latin-1 latin-1 commented Jul 2, 2024

Summary

Because this function supports both jest@<27 and jest@>=27, it should be an intersection of two types rather than a union.

Test plan

// no type errors
const getCacheKey: AsyncTransformer["getCacheKey"] = createCacheKey();

Copy link

netlify bot commented Jul 2, 2024

Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit ca58cfa
🔍 Latest deploy log https://app.netlify.com/sites/jestjs/deploys/6688157ec5b9b40008811f9d
😎 Deploy Preview https://deploy-preview-15159--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@latin-1 latin-1 marked this pull request as ready for review July 2, 2024 14:47
@latin-1 latin-1 force-pushed the patch-1 branch 2 times, most recently from 279a10c to 164c2a6 Compare July 2, 2024 16:44
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point 👍

@SimenB SimenB merged commit 9c11549 into jestjs:main Jul 12, 2024
84 checks passed
@latin-1 latin-1 deleted the patch-1 branch July 12, 2024 08:36
@SimenB
Copy link
Member

SimenB commented Aug 8, 2024

Copy link

github-actions bot commented Sep 8, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants