chore!: drop support for Node.js 21 #15118
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for jestjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
mrazauskas
commented
Jun 10, 2024
| @@ -24,7 +24,8 @@ describe('Wrong globals for environment', () => { | |||
| assertFailuresAndSnapshot(['node', '-t=document']); | |||
| }); | |||
|
|
|||
| onNodeVersions('<21', () => { | |||
| // Node.js 18 is the last LTS version, which is missing the global 'navigator' | |||
| onNodeVersions('<=18', () => { | |||
There was a problem hiding this comment.
This test will be obsolete after dropping Node.js 18. So I though, perhaps keeping 18 here makes it easier to notice that?
|
@SimenB Could you take a look, please? GHA is waiting for status checks on Node v21.x, because these are marked as required. Not so easy to remove them (; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Perhaps it is time to drop Node.js 21? It is end-of-life since 2024-06-01. Reference: https://github.com/nodejs/Release
Test plan
Green CI.