-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: produce sourcemaps when building Jest #14591
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for jestjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
@liuxingbaoyu does something like this work for you? Before I spend more time on removing the extra frames in stacks 😅 |
@@ -273,11 +275,21 @@ export function createBuildConfigs() { | |||
moduleIds: 'named', | |||
}, | |||
output: { | |||
devtoolModuleFilenameTemplate(info) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is to get relative paths in the sourcemaps instead of the absolute path from the machine of the person running the build
Amazing! It's working now, a few places where I can't set breakpoints than before, but not important. |
Cool, thanks for confirming 👍 |
This PR is stale because it has been open 1 year with no activity. Remove stale label or comment or this will be closed in 30 days. |
Summary
This will make debugging Jest itself easier. Not sure if we should include them in the tarball when publishing, but possibly? Then we could probably also minify the code
Test plan
Green CI (eventually)