Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/frame node #745

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

mokaddem
Copy link

Hi @jerosoler!

One again, thanks for this really cool project!

I started to have complex flows and thought it would make sense to organize nodes by grouping them together. Hence, the introduction of "Frame nodes".

Here is how you can use it

const frameNode = {
    nodes: [4, 5],
    text: "Frame node with a text",
    class: "custom-framenode-class",
}
editor.addFrameNode(frameNode)

Along with an screenshot
image

Apologies in advance that this PR requires #687 to be merged before (you can still cherry-pick if you want).
Anyway, let me know if you'd like me to change something for it to be merged.

Cheers

mokaddem added 2 commits May 3, 2023 10:57
Enable the display of labels (passed by HTML) in the middle of a link.
@jerosoler
Copy link
Owner

Hi!

@mokaddem thanks! for PR.
Looks good! I'll take a look at it.

🎉🎉

@converseKarl
Copy link

Jero this looks good and you should definitely merge this in for the community.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants