Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call getHeaders() to load all groups, rather than expecting a string of groups with a delimiter #48

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mamccorm
Copy link

@mamccorm mamccorm commented Aug 11, 2022

I'm not sure if this is something that the maintainers will want to merge, however we faced an issue when using this plugin with another third party application.

It seems that the plugin expects to receive a single string of groups, with a pipe '|' as a delimiter. We're not quite sure why it was implemented this way, but it doesn't seem to be the standard way that groups would be passed in via the headers.

We've forked the plugin and made this change. Thought it worth highlighting via PR in case it was something you wanted to consider re-factoring / merging in.

The changes in this PR replace getHeader() with a call to getHeaders().

  • [X ] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • [X ] Ensure that the pull request title represents the desired changelog entry
  • [X ] Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • [X ] Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@mamccorm mamccorm changed the title Call getHeaders() to load all plugins, rather than expecting a list of plugins with a delimiter Call getHeaders() to load all groups, rather than expecting a string of groups with a delimiter Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant