Return root stages if they have child steps. #377
Conversation
|
Doesn't fix the graph not showing the stage: |
| if (errorAction != null) { | ||
| // If this is a Jenkins failure exception, then we don't need to add a new node | ||
| // - it will come from an existing step if there is a stage for the step to be part of. | ||
| if (hasStage && PipelineNodeUtil.isJenkinsFailureException(errorAction.getError())) { |
There was a problem hiding this comment.
I think this will fix it for no stages, but does this fix withCredentials in a stage? I think that's where I got stuck because its a block scoped step, it wasn't handled.
|
No, the step blocks aren't returned. This does fix the problem of the root Pipeline Start node being filtered out regardless of it it has a step (or exception). |
|
Makes sense I had a similar fix but stopped because of the above but this makes it a bit better so may as well proceed |
Return stages root if they have a child step - we cannot move those to a parent.
Fix for #357, fork of #363.
Testing done
Tested manually
Submitter checklist