Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documented way to look into inward tokens and results of lookup in userInfo endpoint #479

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

arymkus
Copy link

@arymkus arymkus commented Dec 14, 2024

Documented way to look into inward tokens or results of lookup in userInfo endpoint

#478

Testing done

No tests required, only documentation update.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@arymkus arymkus requested a review from a team as a code owner December 14, 2024 17:49
Copy link

codecov bot commented Dec 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.73%. Comparing base (84359ac) to head (0b8fed9).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #479   +/-   ##
=========================================
  Coverage     71.73%   71.73%           
  Complexity      222      222           
=========================================
  Files            17       17           
  Lines          1033     1033           
  Branches        148      148           
=========================================
  Hits            741      741           
  Misses          201      201           
  Partials         91       91           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arymkus arymkus changed the title Arymkus patch 1 Documented way to look into inward tokens or results of lookup in userInfo endpoint Dec 18, 2024
@arymkus arymkus changed the title Documented way to look into inward tokens or results of lookup in userInfo endpoint Documented way to look into inward tokens and results of lookup in userInfo endpoint Dec 18, 2024

## Enabling debug logging

Go to System Log and create a new logger with these classpaths and log levels:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but could potentially leak sensitive information unencrypted on disk.

Perhaps worth mentioning in an admonition that this should be used for a unique test account that should be removed after setup, or only enabled for a short time and log files deleted


## When/why?

When it's not really well documented on IDP's side which specific fields names should be used in plugin's attribute mapping.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most common Idps do document this somewhere.
Perhaps it would be worth creating a table of common values for well known Idps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants